On Wed, Sep 27, 2017 at 1:53 AM, Daniel Stone <[email protected]> wrote:

> Hi,
>
> On 26 September 2017 at 23:55, Jason Ekstrand <[email protected]>
> wrote:
> >  static void
> > -wsi_wl_display_destroy(struct wsi_wl_display *display)
> > +wsi_wl_display_ref(struct wsi_wl_display *display)
> > +{
> > +   display->refcount++;
> > +}
>
> Better:
> static struct wsi_wl_display *
> wsi_wl_display_ref(struct wsi_wl_display *display)
> {
>    display->refcount++;
>    return display;
> }
>
> Makes it much more difficult to get it wrong. :)
>

Yeah.  I thought about doing that the first time around but decided against
it for no good reason.  You've pushed me over the edge back into sanity. :)
_______________________________________________
mesa-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to