On 29 August 2017 at 20:56, Thomas Helland <[email protected]> wrote:
> ---
> src/util/tests/string_buffer/append_and_print.c | 99 ----------
> src/util/tests/string_buffer/append_and_print.cpp | 221
> ++++++++++++++++++++++
> 2 files changed, 221 insertions(+), 99 deletions(-)
> delete mode 100644 src/util/tests/string_buffer/append_and_print.c
> create mode 100644 src/util/tests/string_buffer/append_and_print.cpp
>
I think this should be squashed with 2/8. Some Makefile fixes that
would need to be applied:
append_and_print_SOURCES = \
<tab>append_and_print.cpp
append_and_print_LDADD = \
<tab>$(top_builddir)/src/gtest/libgtest.la
> +++ b/src/util/tests/string_buffer/append_and_print.cpp
> @@ -0,0 +1,221 @@
...
> +int
> +main(int argc, char **argv)
> +{
...
> +}
> +
Seems like copy/paste from the .C file. Do we need it?
...
> \ No newline at end of file
Please add the trailing newline.
-Emil
_______________________________________________
mesa-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
