On Friday, August 18, 2017 10:05:46 PM PDT Jason Ekstrand wrote: > On Thu, Aug 17, 2017 at 4:36 PM, Kenneth Graunke <[email protected]> > wrote: > > > We handle the Sandybridge multisampled 2D surface hack here, rather > > than in ISL, because it requires allocating a BO, and is kind of messy. > > --- > > src/mesa/drivers/dri/i965/Makefile.sources | 2 - > > src/mesa/drivers/dri/i965/brw_context.c | 4 +- > > src/mesa/drivers/dri/i965/brw_context.h | 5 - > > src/mesa/drivers/dri/i965/brw_state.h | 8 - > > src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 119 ++++++-------- > > src/mesa/drivers/dri/i965/gen7_wm_surface_state.c | 180 > > ---------------------- > > src/mesa/drivers/dri/i965/gen8_surface_state.c | 82 ---------- > > 7 files changed, 49 insertions(+), 351 deletions(-) > > > > Look at that diffstat. :-)
Indeed! Deleting copyright headers / files saves quite a few lines :)
> Not really sure why you felt the need to drop the brw_ I don't really care
> that much though.
Mesa style is to skip _mesa_ prefixes on static functions. I usually
try to follow that convention for brw_ prefixes too. I guess I thought
about it as unifying {brw,gen7,gen8}_emit_null_surface_state into a
single function, which I named simply emit_null_surface_state.
But you're right, in the diff it looks funny and unrelated. It's not
really necessary either. *shrug*
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
