On Tue, Jul 25, 2017 at 10:15 AM, Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 25 July 2017 at 03:46, Chih-Wei Huang <cwhu...@android-x86.org> wrote: >> On Tue 11 Jul 2017, Rob Herring wrote: >>>> From: Marek Olšák <marek.ol...@amd.com> >>>> >>>> Add support for 32-bit RGBX/RGBA formats which are required for Android. >>>> >>>> The original patch (commit ccdcf91104a5) was reverted (commit >>>> c0c6ca40a25e) in mesa as it broke GLX resulting in swapped colors. Based >>>> on further investigation by Chad Versace, moving the RGBX/RGBA configs >>>> to the end is enough to prevent breaking GLX. >>>> >>>> The handling of RGBA/RGBX in dri_fill_st_visual is a fix from Marek >>>> Olšák. >>>> >>>> Cc: Eric Anholt <e...@anholt.net> >>>> Cc: Chad Versace <chadvers...@chromium.org> >>>> Cc: Mauro Rossi <issor.or...@gmail.com> >>>> Reviewed-by: Marek Olšák <marek.ol...@amd.com> >>>> Signed-off-by: Rob Herring <r...@kernel.org> >>>> --- >>>> v2: >>>> - Incorporated dri_fill_st_visual RGBA/X handling from Marek >>>> - Handle RGBA/X in dri2_drawable_get_buffers for completeness >> >> Hi Rob, >> I'm testing this patch with your gbm_gralloc and mesa 17.1.5. >> Before applying this patch, the SurfaceFlinger sees >> the alpha=8 in RenderEngine::chooseEglConfig() >> > May want to check for patches in the Android EGL (meta) library. > I think, in does/did have a handful of workarounds. > > Is the Android-x86 one in sync with the one RobH uses?
I double checked and I get 8-8-8-8. I'm have HWC2 enabled and SurfaceFlinger is unpatched master branch. Rob _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
