Hi Lucas, On 4 July 2017 at 16:45, Lucas Stach <l.st...@pengutronix.de> wrote: > @@ -146,7 +121,8 @@ free_scanout: > > struct renderonly_scanout * > renderonly_create_gpu_import_for_resource(struct pipe_resource *rsc, > - struct renderonly *ro) > + struct renderonly *ro, > + struct winsys_handle *out_handle) > { > struct pipe_screen *screen = rsc->screen; > struct renderonly_scanout *scanout;
What does this additional parameter do? Are you missing 'if (out_handle) *out_handle = handle'? Aside from that, it looks fine to me, but my knowledge of renderonly (and Gallium winsys bits in general) is weak enough that I can only really offer: Acked-by: Daniel Stone <dani...@collabora.com> Cheers, Daniel _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev