On Fri, Dec 23, 2011 at 11:57 PM, Kenneth Graunke <[email protected]> wrote: > In this code, 'i' loops over the number of virtual GRFs, while 'j' loops > over the number of vector components (0 <= j <= 3). > > It can't possibly be correct to see if bit 'i' is set in the destination > writemask, as it will have values much larger than 3. Clearly this is > supposed to be 'j'. > > Found by inspection. > > Cc: Eric Anholt <[email protected]> > Cc: Matt Turner <[email protected]> > Cc: Christopher James Halse Rogers <[email protected]> > Signed-off-by: Kenneth Graunke <[email protected]> > --- > .../drivers/dri/i965/brw_vec4_copy_propagation.cpp | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > Matt and Christopher, > > Could you test Counter Strike and Civ V with this patch series? > I think it should solve your regressions with the new VS backend. > > Thanks!
The dxlevel 90 trace I gave you now plays back fine. The menu renders properly, and many little graphical glitches seen during the video stress test are also gone. In the mean time, I've apparently hosed my wine configuration, so I'm not having luck duplicating the results, but alas. Thanks a lot for checking this out. I really appreciate it. The series is Tested-by: Matt Turner <[email protected]> _______________________________________________ mesa-dev mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/mesa-dev
