On Tuesday, June 13, 2017 4:45:18 AM PDT Chris Wilson wrote: > Quoting Kenneth Graunke (2017-06-13 01:33:29) > > This doesn't do anything yet, but soon we'll want to know whether an > > access to a buffer section may write that data, or simply reads it. > > This series doesn't got further than boolean, but would it be worth > feeding through map flags? The immediate advantage is that MAP_READ / > MAP_WRITE is clearer than a bool at the end. > -Chris
Yeah, I was tempted to use the MAP_READ/MAP_WRITE enum for clarity. I wasn't sure if the other other MAP_* bits made any sense here, though. I also wasn't sure whether to allow MAP_READ | MAP_WRITE, or require only one flag to be set (MAP_WRITE -> true, MAP_READ -> false, others -> assert?). I suppose I could add an assert that only MAP_READ or MAP_WRITE are set.
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
