As I mentioned to you on IRC... my understanding of the Driver.Scissor callback is that it's a guarantee by the mesa core that whenever Scissor.* changes, Driver.Scissor() gets called if it's there.
Just because nothing cares on the other side of the abstraction barrier doesn't implicitly mean it should be removed. On Fri, Jun 2, 2017 at 8:31 AM, Samuel Pitoiset <[email protected]> wrote: > This is actually useless because this driver call is only used > by the classic DRI drivers which don't support that extension > and probably won't never support it. > > Signed-off-by: Samuel Pitoiset <[email protected]> > --- > src/mesa/main/scissor.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/src/mesa/main/scissor.c b/src/mesa/main/scissor.c > index 1c766f4c41..5f2f61f926 100644 > --- a/src/mesa/main/scissor.c > +++ b/src/mesa/main/scissor.c > @@ -258,9 +258,6 @@ _mesa_WindowRectanglesEXT(GLenum mode, GLsizei count, > const GLint *box) > sizeof(struct gl_scissor_rect) * count); > ctx->Scissor.NumWindowRects = count; > ctx->Scissor.WindowRectMode = mode; > - > - if (ctx->Driver.Scissor) > - ctx->Driver.Scissor(ctx); > } > > > -- > 2.13.0 > > _______________________________________________ > mesa-dev mailing list > [email protected] > https://lists.freedesktop.org/mailman/listinfo/mesa-dev _______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
