Series looks good. One typo below:
>From: Brian Paul <bri...@vmware.com>
>Sent: Thursday, April 27, 2017 10:19 AM
>To: mesa-dev@lists.freedesktop.org
>Cc: Charmaine Lee; Neha Bhende
>Subject: [PATCH 1/2] wglgears.c: add -srgb option
>To test sRGB pixel format selection and sRGB rendering.
>This involves choosing a new pixel format, creating a new context, etc.
>---
> src/wgl/wglgears.c | 91 ++++++++++++++++++++++++++++++++++++++++++++++++++++--
> 1 file changed, 88 insertions(+), 3 deletions(-)
>diff --git a/src/wgl/wglgears.c b/src/wgl/wglgears.c
>index d90d603..7d43822 100644
>--- a/src/wgl/wglgears.c
>+++ b/src/wgl/wglgears.c
>@@ -30,6 +30,7 @@
> * 25th October 2004
> */
...
>+ if (use_srgb) {
>+ /* For sRGB we need to use the wglChoosePixelFormatARB() function,
>+ * and then create a new context, window, etc.
>+ *
>+ * Note: we can't query/use extension functions until after we've
>+ * creatend and bound a rendering context.
s/creatend/created
BTW, can you also add a comment that we can only set the pixel format of the
window
once, so we need to create a new device context in order to use the pixel
format returned
from wglChoosePixelFormatARB.
Other than that,
Reviewed-by: Charmaine Lee <charmai...@vmware.com>
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
