On Wednesday, April 5, 2017 5:10:15 AM PDT Chris Wilson wrote: > On Tue, Apr 04, 2017 at 05:09:50PM -0700, Kenneth Graunke wrote: > > I apologize that it may be difficult to review: most people aren't > > familiar with this code (I learned a lot myself), and it's kind of > > huge. I tried. > > One thing I will mention is that I put a lot of effort into trying to > explain why brw_batch.c behaves as it does and how it expects the kernel > to behave in relation to itself. Those comments are probably more > valuable than the code contributions... > -Chris
Yeah, you wrote a ton of good comments. I definitely want them. I'll add importing them to the TODO list... --Ken
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
