On Wednesday, April 5, 2017 3:33:39 AM PDT Chris Wilson wrote: > On Tue, Apr 04, 2017 at 05:10:15PM -0700, Kenneth Graunke wrote: > > This moves the PCI ID detection to intel_screen.c and makes > > drm_bacon_bufmgr_gem_init() take a devinfo pointer. > > > > We also drop the HAS_LLC query stuff - devinfo has that info already, > > without kernel queries, and it makes no sense to have two has_llc flags > > set by different mechanisms. > > Just remember the kernel query actually tells you something more than > what you know from just querying pci-id. As you replace the buffer cache > management, that will become more obvious (and directly controllable).
It does? I must be missing something - it sure looks like the kernel sets dev_priv->info.has_llc based on the PCI ID, and this getparam just returns that that value. I'd be happy to set our devinfo->has_llc based on the kernel query, if it's actually useful...but it looks kinda pointless... > Reviewed-by: Chris Wilson <ch...@chris-wilson.co.uk> > > We are still managing multiple pci-id lists. We gave ourselves the goal > many, many years ago of having a single canonical list. > -Chris
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
