Seems reasonable Reviewed-by: Jason Ekstrand <[email protected]> Cc: "17.0 13.0" <[email protected]>
On Sat, Mar 18, 2017 at 4:20 AM, Randy Xu <[email protected]> wrote: > From: "Xu,Randy" <[email protected]> > > The crash is due to NULL pColorBlendState, which is legal if the > pipeline has rasterization disabled or if the subpass of the render pass > the pipeline is created against does not use any color attachments. > > Test: Sample subpasses from LunarG can run without crash > > Signed-off-by: Xu,Randy <[email protected]> > --- > src/intel/vulkan/genX_pipeline.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/intel/vulkan/genX_pipeline.c b/src/intel/vulkan/genX_ > pipeline.c > index cfc7c06..85a9e4f 100644 > --- a/src/intel/vulkan/genX_pipeline.c > +++ b/src/intel/vulkan/genX_pipeline.c > @@ -902,7 +902,7 @@ emit_cb_state(struct anv_pipeline *pipeline, > /* We can have at most 8 attachments */ > assert(i < 8); > > - if (binding->index >= info->attachmentCount) > + if (info == NULL || binding->index >= info->attachmentCount) > continue; > > assert(binding->binding == 0); > @@ -1423,7 +1423,7 @@ emit_3dstate_ps(struct anv_pipeline *pipeline, > * source blend factors. > */ > bool dual_src_blend = false; > - if (wm_prog_data->dual_src_blend) { > + if (wm_prog_data->dual_src_blend && blend) { > for (uint32_t i = 0; i < blend->attachmentCount; i++) { > const VkPipelineColorBlendAttachmentState *bstate = > &blend->pAttachments[i]; > -- > 2.7.4 > > _______________________________________________ > mesa-dev mailing list > [email protected] > https://lists.freedesktop.org/mailman/listinfo/mesa-dev >
_______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
