Hi Tim, Please use something like " src/compiler/glsl/tests/cache_test: track correct folder for the disk cache"
On 6 March 2017 at 02:25, Timothy Arceri <[email protected]> wrote: > Fixes make check after 11f0efec2e615f5233d which caused disk cache > to create an additional directory. Fixes: 11f0efec2e6 ("util/disk_cache: support caches for multiple architectures") > static void > -check_timestamp_and_gpu_id_directories_created(const char *cache_dir) > +check_timestamp_and_gpu_id_directories_created(char *cache_dir) Seemingly unrelated change ? Please keep separate or mention in the commit summary. > + /* Create string with expected directory hierarchy */ > + char expected_dir_h[255]; > + sprintf(expected_dir_h, "%s%s%s", CACHE_TEST_TMP "/xdg-cache-home/mesa/", > + get_arch_bitness_str(), "/make_check/test"); > + Really want to keep all the magic paths in one place. Just throw this in a helper - even if it's a define macro. I think we have another case in the file that could use the same tls. > > +static inline const char * > +get_arch_bitness_str(void) Please mention [in the commit summary] that we fix things by reusing this function, also do use a disk_cache_ prefix. Thanks Emil _______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
