On 02/27/2017 03:42 PM, Emil Velikov wrote:
On 27 February 2017 at 05:53, Tapani Pälli <tapani.pa...@intel.com> wrote:
This is a DRI3 version of a change made for DRI2
(4d6d4f939e0af4252e0b, "egl/dri2: implement query surface hook"),
that fixed failures in dEQP-EGL.functional.resize.surface_size.grow
and dEQP-EGL.functional.resize.surface_size.shrink.
Do these tests fail on some platform? When debugging the original
failures this failed for me only when using DRI2. It's nice to be
consistent but is it possible that this is not necessary because of
differences between DRI2 and DRI3?
The tests failed on the PowerVR driver. The tests resize the drawable
before calling eglSwapBuffers, and query the drawable width and height
after the call. The driver hasn't started drawing the next frame at this
point, and so hasn't requested the new buffers for the drawable yet,
hence the old width and height were being returned.
OK thanks for clarifying, these changes look good to me;
Reviewed-by: Tapani Pälli <tapani.pa...@intel.com>
I'm leaning that we'd want this for stable. Worth checking if it
improves the CI runs, or at least that nothing regresses ;-)
Yeah I did that and no changes in results seen.
// Tapani
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
