From: Emil Velikov <emil.veli...@collabora.com> Currently we can build draw without LLVM thus honouring SOFTPIPE_USE_LLVM is misleading even if most of the code nicely falls-back to no-op in the lack of LLVM.
That does not seem to be the case in softpipe_draw_vbo() where extra prepare {prepare,cleanup}_{vertex,geometry}_sampling is present. Haven't checked how much overhead the causes, but omitting it is the correct thing to do, afaict. Note: the topic of "is it a smart idea to have softpipe build with LLVM-less draw" is to be checked another day. Cc: Roland Scheidegger <srol...@vmware.com> Cc: Jose Fonseca <jfons...@vmware.com> Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- It's the better thing to do imho, but if you feel strongly against it feel free to drop it. --- src/gallium/drivers/softpipe/sp_screen.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/softpipe/sp_screen.c b/src/gallium/drivers/softpipe/sp_screen.c index 9bc8d10e8e..1a58eb9d99 100644 --- a/src/gallium/drivers/softpipe/sp_screen.c +++ b/src/gallium/drivers/softpipe/sp_screen.c @@ -568,7 +568,9 @@ softpipe_create_screen(struct sw_winsys *winsys) screen->base.context_create = softpipe_create_context; screen->base.flush_frontbuffer = softpipe_flush_frontbuffer; screen->base.get_compute_param = softpipe_get_compute_param; +#ifdef HAVE_LLVM screen->use_llvm = debug_get_option_use_llvm(); +#endif util_format_s3tc_init(); -- 2.11.0 _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev