On 23/11/16 07:18 PM, Boyan Ding wrote:
2016-11-24 7:01 GMT+08:00 Derek Foreman <der...@osg.samsung.com>:
This is a copy of commit 536003c11e4cb1172c540932ce3cce06f03bf44e
except for i915.
Original log for the i965 commit follows:
Some application, such as drm backend of weston, uses XRGB8888 config as
default. i965 doesn't provide this format, but before commit 65c8965d,
the drm platform of EGL takes ARGB8888 as XRGB8888. Now that commit
65c8965d makes EGL recognize format correctly so weston won't start
because it can't find XRGB8888. Add XRGB8888 format to i965 just as
other drivers do.
Signed-off-by: Derek Foreman <der...@osg.samsung.com>
---
src/mesa/drivers/dri/i915/intel_screen.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/mesa/drivers/dri/i915/intel_screen.c
b/src/mesa/drivers/dri/i915/intel_screen.c
index 1b80df0..5c7c06a 100644
--- a/src/mesa/drivers/dri/i915/intel_screen.c
+++ b/src/mesa/drivers/dri/i915/intel_screen.c
@@ -1044,7 +1044,8 @@ intel_screen_make_configs(__DRIscreen *dri_screen)
{
static const mesa_format formats[] = {
MESA_FORMAT_B5G6R5_UNORM,
- MESA_FORMAT_B8G8R8A8_UNORM
+ MESA_FORMAT_B8G8R8A8_UNORM,
+ MESA_FORMAT_B8G8R8X8_UNORM
};
/* GLX_SWAP_COPY_OML is not supported due to page flipping. */
--
2.10.2
Hi Derek,
I sent exactly the same patch one and half years ago at [1], but
withdrew it because it seems no one got interested in that and I don't
have the hardware to test. If you're sure it is correct, this gets my
Acked-by: Boyan Ding <boyan.j.d...@gmail.com>
I'm sorry, I didn't see your patch. It makes more sense to me that I
give you my RB on that patch in place of your Ack on mine. I don't want
to take credit for a problem you solved over a year ago. :)
I don't have appropriate hardware but this has been tested for me by an
Enlightenment user who was unable to use our GL backend because it's
trying to use XRGB.
Weston ran for him but logged a warning about falling back to an ARGB
visual, which led me to the discovery that this had only been changed
for i965.
I'll try to get him to reply with a "Tested-by" tomorrow.
Regards,
Boyan Ding
[1] https://lists.freedesktop.org/archives/mesa-dev/2015-April/081501.html
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
