Reviewed-by: Marek Olšák <[email protected]> Marek
On Sat, Nov 5, 2016 at 7:00 PM, Brian Paul <[email protected]> wrote: > This fixes random crashes with MSVC release builds. It seems the > members are implicitly initialized to zero with gcc, but not MSVC. > In particular, the tex_offset_num_offset field was non-zero causing > a loop over the NULL tex_offsets array to crash. > > Zero-init those fields and a few others to be safe. > > The regression began with acc23b04cfd64e "ralloc: remove memset from > ralloc_size". > --- > src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp > b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp > index 882e959..a4679e5 100644 > --- a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp > +++ b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp > @@ -680,6 +680,10 @@ glsl_to_tgsi_visitor::emit_asm(ir_instruction *ir, > unsigned op, > inst->is_64bit_expanded = false; > inst->ir = ir; > inst->dead_mask = 0; > + inst->tex_offsets = NULL; > + inst->tex_offset_num_offset = 0; > + inst->saturate = 0; > + inst->tex_shadow = 0; > /* default to float, for paths where this is not initialized > * (since 0==UINT which is likely wrong): > */ > -- > 1.9.1 > > _______________________________________________ > mesa-dev mailing list > [email protected] > https://lists.freedesktop.org/mailman/listinfo/mesa-dev _______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
