On 25 October 2016 at 01:17, Vedran Miletić <[email protected]> wrote: > On 10/25/2016 01:41 AM, Vinson Lee wrote: >> >> Fix SCons build. drmDevicePtr is not available until libdrm 2.4.65. >> >> Compiling src/loader/loader.c ... >> src/loader/loader.c:111:40: error: unknown type name ‘drmDevicePtr’ >> static char *drm_construct_id_path_tag(drmDevicePtr device) >> ^ >> >> Fixes: 4a183f4d06f8 ("scons: loader: use libdrm when available") >> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98421 >> Signed-off-by: Vinson Lee <[email protected]> >> --- >> scons/gallium.py | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/scons/gallium.py b/scons/gallium.py >> index 9f7555cf8bce..8cf6cc732cdc 100755 >> --- a/scons/gallium.py >> +++ b/scons/gallium.py >> @@ -651,7 +651,7 @@ def generate(env): >> env.PkgCheckModules('X11', ['x11', 'xext', 'xdamage', 'xfixes', >> 'glproto >= 1.4.13']) >> env.PkgCheckModules('XCB', ['x11-xcb', 'xcb-glx >= 1.8.1', 'xcb-dri2 >> >= 1.8']) >> env.PkgCheckModules('XF86VIDMODE', ['xxf86vm']) >> - env.PkgCheckModules('DRM', ['libdrm >= 2.4.38']) >> + env.PkgCheckModules('DRM', ['libdrm >= 2.4.65']) >> >> if env['x11']: >> env.Append(CPPPATH = env['X11_CPPPATH']) >> > > That's a large bump and 2.4.65 is just over a year old. It would be nice to > support a couple more versions before. > I have to agree with Michel here. If your distro cannot rebuild the package you're greatly encouraged to do so. 2.4.66 (and later) has been required for a while now.
Vinson, as pointed by Michel, you want 2.4.66 here. drmGetDevices was introduced in 2.4.65 and drmGetDevice (singular) - 2.4.66. With that Reviewed-by: Emil Velikov <[email protected]> -Emil _______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
