On Wed, Oct 12, 2016 at 7:05 PM, Emil Velikov <[email protected]> wrote: > From: Emil Velikov <[email protected]> > > Private/internal symbols should never not be exported. Using the > CXXFLAGS cuts ~300 exported symbols and ~23K from libvulkan_radeon.so.
Double negative? I think the message is much more consistent with single negative. With that, patch 2-5 are Acked-by: Bas Nieuwenhuizen <[email protected]> > > Signed-off-by: Emil Velikov <[email protected]> > --- > src/amd/Makefile.addrlib.am | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/amd/Makefile.addrlib.am b/src/amd/Makefile.addrlib.am > index 434e692..64823fc 100644 > --- a/src/amd/Makefile.addrlib.am > +++ b/src/amd/Makefile.addrlib.am > @@ -30,6 +30,9 @@ addrlib_libamdgpu_addrlib_la_CPPFLAGS = \ > -I$(srcdir)/addrlib/r800/chip \ > -DBRAHMA_BUILD=1 > > +addrlib_libamdgpu_addrlib_la_CXXFLAGS = \ > + $(VISIBILITY_CXXFLAGS) > + > noinst_LTLIBRARIES += $(ADDRLIB_LIBS) > > addrlib_libamdgpu_addrlib_la_SOURCES = $(ADDRLIB_FILES) > -- > 2.10.0 > > _______________________________________________ > mesa-dev mailing list > [email protected] > https://lists.freedesktop.org/mailman/listinfo/mesa-dev _______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
