On 12 October 2016 at 19:04, Tobias Droste <[email protected]> wrote: > Am Mittwoch, 12. Oktober 2016, 09:56:39 CEST schrieb Emil Velikov: >> > fi >> > >> > +if test "x$enable_opencl" = xyes; then >> > + llvm_check_version_for "3" "6" "0" "opencl" >> > + >> > + LLVM_COMPONENTS="${LLVM_COMPONENTS} all-targets ipo linker >> > instrumentation" + LLVM_COMPONENTS="${LLVM_COMPONENTS} irreader option >> > objcarcopts profiledata" +fi >> > + >> > +dnl Check for Clang internal headers >> > +if test "x$enable_opencl" = xyes; then >> >> Nit: drop the second if test, yet preserve the comment ? >> Disclaimer: haven't looked if later patches depend on the split. > > This is a "just move" patch, that's why I didn't change anything. > But this whole section will be changed later (Patch 11) so it actually doesn't > matter. > Patch 11... this hunks get moved once here and a second time in there. Just move it to the "top" from the start, fold the conditional and as you do further movement keep it in the same block ?
Sure I suggested to keep things separate, but it sounds like we got from one end/extreme to the other. Emil _______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
