Thanks Dave for your suggestion! I'll refine the patch. One question: Is there any standard process to bump version on this extension, or I just need to add something to docs/specs/MESA_image_dma_buf_export.txt ?
-----Original Message----- From: Dave Airlie [mailto:[email protected]] Sent: Friday, August 19, 2016 9:47 AM To: Weng, Chuanbo <[email protected]> Cc: Eric Engestrom <[email protected]>; [email protected]; [email protected]; [email protected] Subject: Re: [Mesa-dev] [PATCH] Return corresponding offset of EGLImage instead of 0. On 18 August 2016 at 12:59, Weng, Chuanbo <[email protected]> wrote: > Hi Dave and all, > (Since Dave implemented this extension EGL_MESA_image_dma_buf_export, > so I also send this email to you.) > Could you please review this patch and push it if it looks good to > you? Thanks! I think this needs a version bump on the EGL image interface. It will also break the gallium drivers, as it doesn't check the return value of queryImage, and you haven't patched the other drivers to provide the values or set them to 0. Dave. _______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
