On Tuesday, August 16, 2016 10:01:47 AM PDT Dave Airlie wrote: > From: Dave Airlie <[email protected]> > > I'm not sure if anything even uses this, but I found this on radv, so > just fix it on anv for consistency. > > Signed-off-by: Dave Airlie <[email protected]> > --- > src/intel/vulkan/anv_meta_blit.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/intel/vulkan/anv_meta_blit.c > b/src/intel/vulkan/anv_meta_blit.c > index e8b244b..d2e375a 100644 > --- a/src/intel/vulkan/anv_meta_blit.c > +++ b/src/intel/vulkan/anv_meta_blit.c > @@ -106,7 +106,7 @@ build_nir_copy_fragment_shader(enum glsl_sampler_dim > tex_dim) > nir_variable *color_out = nir_variable_create(b.shader, > nir_var_shader_out, > vec4, "f_color"); > color_out->data.location = FRAG_RESULT_DATA0; > - nir_store_var(&b, color_out, &tex->dest.ssa, 4); > + nir_store_var(&b, color_out, &tex->dest.ssa, 0xf); > > return b.shader; > } >
Yep, this has always been wrong - I pointed out this bug before we even shipped the code, while it was still being frequently rewritten. Looks like it never got fixed though. :( Thanks for finally doing it! Reviewed-by: Kenneth Graunke <[email protected]> We don't use the writemask for fragment shader outputs, so it won't have any effect. Still, much less confusing now :)
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
