On Tue, Jul 26, 2016 at 1:19 PM, Kenneth Graunke <kenn...@whitecape.org> wrote: > The pass I introduced in commit a2dc11a7818c04d8dc0324e8fcba98d60bae > was entirely broken. A missing "break" made the load_interpolated_input > case always fall through to "default" and hit a "continue", making it > not actually move any load_interpolated_input intrinsics at all.
Let's make a rule that non-obvious fallthroughs *must* be marked with a /* fallthrough */ comment. That would have lead reviewers to notice that something was strange. Coverity also makes noise about this, and that would be nice to avoid as well. _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
