This patch is Reviewed-by: Ian Romanick <[email protected]>
On 06/01/2016 11:38 PM, Alejandro Piñeiro wrote: > For ES 3.0 NUM_SAMPLE_COUNTS spec points that some formats will be > always zero. But on ES 3.1 can be different to zero. > > The current code is correctly checking exactly against version 3.0, > but the comment only mentions 3.0 spec. It is clearer mentioning both. > > v2: better wording on the comment (Ian Romanick) > > Acked-by: Eduardo Lima <[email protected]> > Acked-by: Antia Puentes <[email protected]> > --- > src/mesa/main/formatquery.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/mesa/main/formatquery.c b/src/mesa/main/formatquery.c > index 1f21d17..f524619 100644 > --- a/src/mesa/main/formatquery.c > +++ b/src/mesa/main/formatquery.c > @@ -877,6 +877,9 @@ _mesa_GetInternalformativ(GLenum target, GLenum > internalformat, GLenum pname, > * "Since multisampling is not supported for signed and unsigned > * integer internal formats, the value of NUM_SAMPLE_COUNTS will be > * zero for such formats. > + * > + * Since OpenGL ES 3.1 adds support for multisampled integer formats, > we > + * have to check the version for 30 exactly. > */ > if (pname == GL_NUM_SAMPLE_COUNTS && ctx->API == API_OPENGLES2 && > ctx->Version == 30 && > _mesa_is_enum_format_integer(internalformat)) { > _______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
