On 05/26/2016 03:39 PM, Ilia Mirkin wrote: > On Thu, May 26, 2016 at 6:26 PM, Ian Romanick <[email protected]> wrote: >> On 05/26/2016 03:03 PM, Ilia Mirkin wrote: >>> This will cause st/mesa to break, no? Right now validate_io iterates >>> over the shader ir, which st/mesa frees after linking. >> >> Only as much as it is already broken. :) Any desktop OpenGL application >> using GLSL ES shaders would already have that problem. I suspect there >> are more of those than there are applications using debug contexts. I > > Doesn't glretrace create a debug context? Maybe I'm just imagining > things. One would have to do SSO in ES to observe the breaks right > now, which I think is pretty rare.
I don't know much of anything about glretrace. It would make sense for it to at least have an option to create a debug context. >> believe this should all be cleared up after patch 6 in this series which >> deletes the old validate_io function. > > Yeah... I'm just hoping this can get ordered after that patch. Or at > least be in the same series. I put the original version of this patch at this point in the series so that I wouldn't have to put ES checking in the next patch. In fact, that was the patch's raison d'être. I plan to land all of these together, and I don't think any of them will get cherry-picked to earlier releases. I can rearrange them if you /really/ want me to. :) > -ilia _______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
