On Sun, Apr 10, 2016 at 10:23 PM, <[email protected]> wrote: > I didn't see anything obviously wrong so, > > Reviewed-by: Edward O'Callaghan <[email protected]> > > But I have some general questions about guard band, not sure if this is the > right place but I'll just ask any way: > From my somewhat naive understanding guard band can lead to small gaps > between polygons. In this implementation what exactly happens when on the > screen bounds as clipped triangle could wind up with different edge slopes?
Doesn't seem like that's an issue with modern hw. I defer to Fabian: https://fgiesen.wordpress.com/2011/07/05/a-trip-through-the-graphics-pipeline-2011-part-5/#comment-162 Kristian > Does this clip to the guard band edge or does it clip to the screen edge and > if so what is the pixel cost on SI with that? > > > On 2016-04-11 08:34, Marek Olšák wrote: >> >> Hi, >> >> This patch series adds Guard Band support into r600g and radeonsi. >> >> It first implements the Guard Band in radeonsi, then it moves all >> radeonsi scissor & viewport code into gallium/radeon, and then r600g >> is switched to it and its original scissor & viewport code is deleted. >> >> The differences between the R600 and GCN code are almost none. >> >> This should improve performance if clipping is the bottleneck. >> >> Grigori Goronzy started this originally. >> >> Please review. >> >> Marek >> _______________________________________________ >> mesa-dev mailing list >> [email protected] >> https://lists.freedesktop.org/mailman/listinfo/mesa-dev > > > _______________________________________________ > mesa-dev mailing list > [email protected] > https://lists.freedesktop.org/mailman/listinfo/mesa-dev _______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
