On Tuesday, April 5, 2016 2:26:59 PM PDT kevin.rogo...@intel.com wrote: > From: Kevin Rogovin <kevin.rogo...@intel.com> > > This patch sequence enforces an extra check > for GenQueriesARB and DeleteQueriesARB that > is not preset in GenQueries and DeleteQueries. > > Kevin Rogovin (2): > Differentiate between GenQueries and GenQueriesARB > Differentiate between DeleteQueries and DeleteQueriesARB > > src/mapi/glapi/gen/gl_API.xml | 4 ++-- > src/mesa/main/context.c | 1 + > src/mesa/main/queryobj.c | 51 +++++++++++++++++++++++++++++++++++++ +----- > src/mesa/main/queryobj.h | 4 ++++ > 4 files changed, 52 insertions(+), 8 deletions(-)
NAK for the series. There is no reason to reject GenQueries during an active query - all it does is create a name. It's completely harmless. You are correct that the ARB_occlusion_query specification does say that an error should be generated. However, I believe the fact that no OpenGL specification includes this error is because it was removed intentionally, and should be treated as a clarification / bug fix. Khronos bug #7612 calls this a "bug fix", and mentions that the specification was updated to match shipping implementations: https://cvs.khronos.org/bugzilla/show_bug.cgi?id=7612 Also, making the ARB and non-ARB versions behave differently over an error that nobody wants seems pretty asinine, IMO. For reference, we removed this error in commit 29996e219912fb1fdf35a6595d8f6261384a18dc.
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
