2016-04-01 2:40 GMT+08:00 Jaap Jan Meijer <[email protected]>: > Op donderdag 31 maart 2016 13:02:36 UTC+2 schreef Chih-Wei Huang: > Thanks for the patch, I tested it on both x86 and x64 kernels and it doesn't > crash anymore, previously it did on both. > >> Thanks for the fix. I'll apply it. >> But Jaap uses i915 which is a classical driver. >> I doubt if it's related to the gallium_dri.so. >> >> Jaap, did you use a 64-bit kernel to test? > > You are right but because of the driver selection strategy chosen in > gralloc_drm.c it will always first try the pipe driver whenever it is > enabled.
As I've said I didn't encounter the crashing so I don't think it's an issue. If you didn't enable any pipe driver, it won't try to call gralloc_drm_drv_create_for_pipe (ENABLE_PIPE is not set). If you enabled a pipe driver, load_pipe_screen should exist and it won't crash. I suspect you changed BOARD_GPU_DRIVERS but didn't rebuild both drm_gralloc and mesa properly so the GPU configuration mismatched. This is considered a flaw of the makefiles however it's not easy to be fixed. As a rule of thumb, if you changed BOARD_GPU_DRIVERS, you should clean both drm_gralloc and mesa object files manually to ensure they are rebuilt properly. Anyway, I agree Robh's patch is a safe guard to avoid some possible issues. -- Chih-Wei Android-x86 project http://www.android-x86.org _______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
