Reviewed-by: Samuel Iglesias Gonsálvez <[email protected]> Sam
On Thu, Mar 03, 2016 at 02:15:39AM -0800, Kenneth Graunke wrote:
> dEQP-GLES31.functional.fbo.no_attachments.maximums.{all,height,size,width}
> started hitting assertion failures when emitting SURFACE_STATE, after
> commit e8fd60e7891c7 where Samuel increased the maximum viewport size to
> 32768, from 16384.
>
> MaxFramebufferWidth/Height were being set to the maximum viewport size,
> but are actually limited by the SURFACE_STATE width/height field range,
> which is 16384 on Gen7+ (where ARB_framebuffer_no_attachments is
> exposed). So, reduce these to 16384 explicitly.
>
> Fixes assert fails in the above mentioned dEQP tests. (Those tests
> still fail, however.)
>
> Signed-off-by: Kenneth Graunke <[email protected]>
> ---
> src/mesa/drivers/dri/i965/brw_context.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_context.c
> b/src/mesa/drivers/dri/i965/brw_context.c
> index f5e4ace..8dcb3f2 100644
> --- a/src/mesa/drivers/dri/i965/brw_context.c
> +++ b/src/mesa/drivers/dri/i965/brw_context.c
> @@ -703,8 +703,8 @@ brw_initialize_context_constants(struct brw_context *brw)
> ctx->Const.MaxVertexStreams = MIN2(4, MAX_VERTEX_STREAMS);
>
> /* ARB_framebuffer_no_attachments */
> - ctx->Const.MaxFramebufferWidth = ctx->Const.MaxViewportWidth;
> - ctx->Const.MaxFramebufferHeight = ctx->Const.MaxViewportHeight;
> + ctx->Const.MaxFramebufferWidth = 16384;
> + ctx->Const.MaxFramebufferHeight = 16384;
> ctx->Const.MaxFramebufferLayers = ctx->Const.MaxArrayTextureLayers;
> ctx->Const.MaxFramebufferSamples = max_samples;
> }
> --
> 2.7.2
>
>
signature.asc
Description: PGP signature
_______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
