Thanks Eric, that makes sense. I'll respin the patch, confirm no piglit regressions and send it back to the mailing list for your R-b.
Regards, Rhys On Friday, February 12, 2016, Eric Anholt <[email protected]> wrote: > Rhys Kidd <[email protected] <javascript:;>> writes: > > > Variable no longer is read, and always set to true. > > > > Accordingly, the later assert() serves no active current purpose. The > prior > > limb of the test 'qinst->cond == QPU_COND_ALWAYS' will never trigger an > assert() > > as is. If it did previously define a relevant test, this should be > revisited > > in a subsequent patch. > > Looks like just a typo, was supposed to be set to false at the top. > Only the default case handles a cond on the qinst so far, so we want to > be sure that we didn't try to put a cond on any other type of qinst. >
_______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
