On 2015-12-05 01:33, Emil Velikov wrote:
Hi Edward,

A few trivial suggestions (for future patches) and a humble request

On 4 December 2015 at 06:50, Edward O'Callaghan
<[email protected]> wrote:
Signed-off-by: Edward O'Callaghan <[email protected]>
---
 src/gallium/winsys/amdgpu/drm/amdgpu_surface.c | 6 ++----
For the patches do shorten up the prefix - here we'd want
"winsys/amdgpu" while on the driver side just "nouveau" or "llvmpipe"
should suffice. When in doubt git log is your friend

Sure no worries, will do on future patches. Thanks.


You mentioned that you've done these with a Coccinelle schematic patch
(script) - mind if we get that (actually start collecting) in tree ...
perhaps in bin/ or bin/cocci/ ?

Definitely! This is in fact part of my proposed plan after I get some of
the major churn out the way and see what passes review and hence which
.cocci scripts are suitable for mesa.


Thanks
Emil

Kind Regards,
_______________________________________________
mesa-dev mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to