-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Kenneth Graunke wrote: > On Thursday 07 October 2010 16:34:47 Chad Versace wrote: >> From: Chad Versace <[email protected]> >> >> --- >> src/glsl/glsl_types.h | 9 +++++++++ >> 1 files changed, 9 insertions(+), 0 deletions(-) >> >> diff --git a/src/glsl/glsl_types.h b/src/glsl/glsl_types.h >> index dccab0a..da38d48 100644 >> --- a/src/glsl/glsl_types.h >> +++ b/src/glsl/glsl_types.h >> @@ -249,6 +249,15 @@ struct glsl_type { >> } >> >> /** >> + * \brief Query whether or not a type is a vector >> + */ >> + bool is_integer_vector() const > > This function name doesn't match the one in your commit message... > >> + { >> + return is_vector() >> + and (base_type == GLSL_TYPE_INT or base_type == >> GLSL_TYPE_UINT); + } > > Please use && and ||.
Yes. Most of the Mesa developers are C programmers, so these changed C++ keywords will likely be unfamiliar to them. > Rather than adding this function, you can pretty easily just do: > type->is_integer() && type->is_vector() Yes. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAkyuacwACgkQX1gOwKyEAw8FiACfUe9q308rPe0neaIgZm29eSAd WlIAoKAeAUX3lPfGHfTGRXRpmheooNG4 =rMFA -----END PGP SIGNATURE----- _______________________________________________ mesa-dev mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/mesa-dev
