Module: Mesa Branch: master Commit: 63b03dc924adf91ecb5da757edafa975878d7047 URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=63b03dc924adf91ecb5da757edafa975878d7047
Author: Brian Paul <[email protected]> Date: Thu Dec 7 15:00:49 2017 -0700 gallium/util: don't pass a pipe_resource to util_resource_is_array_texture() No need to pass a pipe_resource when we can just pass the target. This makes the function potentially more usable. Rename it too. Reviewed-by: Roland Scheidegger <[email protected]> Reviewed-by: Charmaine Lee <[email protected]> Reviewed-by: Marek Olšák <[email protected]> --- src/gallium/auxiliary/util/u_resource.h | 6 +++--- src/gallium/drivers/radeon/r600_texture.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/gallium/auxiliary/util/u_resource.h b/src/gallium/auxiliary/util/u_resource.h index 6736476f4d..3c6194b8f0 100644 --- a/src/gallium/auxiliary/util/u_resource.h +++ b/src/gallium/auxiliary/util/u_resource.h @@ -32,14 +32,14 @@ unsigned util_resource_size(const struct pipe_resource *res); /** - * Return true if the resource is an array texture. + * Return true if the texture target is an array type. * * Note that this function returns true for single-layered array textures. */ static inline boolean -util_resource_is_array_texture(const struct pipe_resource *res) +util_texture_is_array(enum pipe_texture_target target) { - switch (res->target) { + switch (target) { case PIPE_TEXTURE_1D_ARRAY: case PIPE_TEXTURE_2D_ARRAY: case PIPE_TEXTURE_CUBE_ARRAY: diff --git a/src/gallium/drivers/radeon/r600_texture.c b/src/gallium/drivers/radeon/r600_texture.c index cb69398e6a..66d4f02622 100644 --- a/src/gallium/drivers/radeon/r600_texture.c +++ b/src/gallium/drivers/radeon/r600_texture.c @@ -582,7 +582,7 @@ static void si_query_opaque_metadata(struct si_screen *sscreen, PIPE_SWIZZLE_W }; uint32_t desc[8], i; - bool is_array = util_resource_is_array_texture(res); + bool is_array = util_texture_is_array(res->target); /* DRM 2.x.x doesn't support this. */ if (sscreen->info.drm_major != 3) _______________________________________________ mesa-commit mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-commit
