Module: Mesa
Branch: master
Commit: 940fba68c903d9b4da2d99a68f1c06c53d4fe82a
URL:    
http://cgit.freedesktop.org/mesa/mesa/commit/?id=940fba68c903d9b4da2d99a68f1c06c53d4fe82a

Author: Brian Paul <[email protected]>
Date:   Mon Nov  6 18:11:38 2017 -0700

util/tgsi: use ASSERT_BITFIELD_SIZE() to check opcode field size

I've noticed at least two places where we store the TGSI opcode in
an unsigned:8 bitfield.  We're at 249 opcodes now.  If we hit 256 we'll
need to grow those bitfields.  Use the new ASSERT_BITFIELD_SIZE() macro
to detect that.

Reviewed-by: Nicolai Hähnle <[email protected]>

---

 src/gallium/auxiliary/tgsi/tgsi_info.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/gallium/auxiliary/tgsi/tgsi_info.c 
b/src/gallium/auxiliary/tgsi/tgsi_info.c
index 4e399508e5..c39de0edfc 100644
--- a/src/gallium/auxiliary/tgsi/tgsi_info.c
+++ b/src/gallium/auxiliary/tgsi/tgsi_info.c
@@ -55,6 +55,8 @@ tgsi_get_opcode_info( uint opcode )
 {
    static boolean firsttime = 1;
 
+   ASSERT_BITFIELD_SIZE(struct tgsi_opcode_info, opcode, TGSI_OPCODE_LAST - 1);
+
    if (firsttime) {
       unsigned i;
       firsttime = 0;

_______________________________________________
mesa-commit mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/mesa-commit

Reply via email to