Module: Mesa
Branch: master
Commit: 6e2b87c7e92b090dc2a08735f6ac96a95266730b
URL:    
http://cgit.freedesktop.org/mesa/mesa/commit/?id=6e2b87c7e92b090dc2a08735f6ac96a95266730b

Author: Thomas Hellstrom <[email protected]>
Date:   Thu Sep  7 10:45:10 2017 +0200

mesa/st: Fix frontbuffer rendering regression

This fixes a regression introduced with commit
"mesa/st: Reduce the number of frontbuffer flush calls"
where we, after flushing the front buffer marked it as not-rendered-to,
the idea being that it should be marked as "rendered-to" again as soon as
any rendering was touching the front.

Now the latter part never happened, because it was part of a state
validation and we never marked that part of the state as dirty.

So mark the framebuffer state dirty after a frontbuffer flush.
(fdo bugzilla 102496)

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102496
Fixes: eceb671002 (mesa/st: Reduce the number of frontbuffer flush calls)
Signed-off-by: Thomas Hellstrom <[email protected]>
Reviewed-by: Bruce Cherniak <[email protected]>
Reviewed-by: Marek Olšák <[email protected]>
Tested-by: Dieter Nützel <[email protected]>
Tested-by: Bruce Cherniak <[email protected]>
Tested-By: Gert Wollny <[email protected]>

---

 src/mesa/state_tracker/st_manager.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/mesa/state_tracker/st_manager.c 
b/src/mesa/state_tracker/st_manager.c
index 07c430dca4..6c7d836827 100644
--- a/src/mesa/state_tracker/st_manager.c
+++ b/src/mesa/state_tracker/st_manager.c
@@ -1044,6 +1044,9 @@ st_manager_flush_frontbuffer(struct st_context *st)
       stfb->iface->flush_front(&st->iface, stfb->iface,
                                ST_ATTACHMENT_FRONT_LEFT);
       strb->defined = GL_FALSE;
+
+      /* Trigger an update of strb->defined on next draw */
+      st->dirty |= ST_NEW_FB_STATE;
    }
 }
 

_______________________________________________
mesa-commit mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/mesa-commit

Reply via email to