Module: Mesa Branch: main Commit: 904015ae855a6a3ae4d25a38e593410be60d1aa5 URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=904015ae855a6a3ae4d25a38e593410be60d1aa5
Author: Vinson Lee <[email protected]> Date: Sun Nov 12 10:33:43 2023 -0800 ac/surface/tests: Remove duplicate variable block_size_bits Fix defect reported by Coverity Scan. Evaluation order violation (EVALUATION_ORDER) write_write_typo: In block_size_bits = block_size_bits = ((surf.u.gfx9.swizzle_mode >= ADDR_SW_256KB_Z_X) ? 18 : 16), block_size_bits is written twice with the same value. Fixes: 44eaf50a34b ("ac/surface/tests: cosmetic changes") Signed-off-by: Vinson Lee <[email protected]> Reviewed-by: Marek Olšák <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26160> --- src/amd/common/ac_surface_modifier_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/common/ac_surface_modifier_test.c b/src/amd/common/ac_surface_modifier_test.c index 49854a8ff8f..82d2d4d6f50 100644 --- a/src/amd/common/ac_surface_modifier_test.c +++ b/src/amd/common/ac_surface_modifier_test.c @@ -261,7 +261,7 @@ static void test_modifier(const struct radeon_info *info, unsigned aligned_pitch, aligned_height; if (modifier != DRM_FORMAT_MOD_LINEAR) { unsigned block_size_bits = - block_size_bits = surf.u.gfx9.swizzle_mode >= ADDR_SW_256KB_Z_X ? 18 : 16; + surf.u.gfx9.swizzle_mode >= ADDR_SW_256KB_Z_X ? 18 : 16; surf_size = block_count(dims[i][0], dims[i][1], elem_bits, block_size_bits, &aligned_pitch,
