I re-submitted (#11429) after applying your comments.
My answers below
> -----Original Message-----
> From: Arjan van de Ven [mailto:[email protected]]
> Sent: Tuesday, January 04, 2011 4:03 PM
> To: [email protected]
> Cc: Mahe, ErwanX; [email protected]
> Subject: Re: [meego-commits] 11415: New package Trunk:Testing/rfkill
>
> On 1/4/2011 6:35 AM, Erwanx Mahe wrote:
> > Hi,
> > Adding new package rfkill in project Trunk:Testing. Please review and accept
> ASAP.
> >
> > Justification for this new package:
>
> I don't know where you got this package spec from (please use spectacle)
>
> but it does not look like a MeeGo spec file.
>
I got it from a fedora, I didn't realize that it had to be repackaged for MeeGo
>
> > %build
> > make %{?_smp_mflags} CFLAGS="$RPM_OPT_FLAGS"
>
> like the CFLAGS thing we don't need/do
> >
> > %install
> > rm -rf $RPM_BUILD_ROOT
> or this
>
> > make install DESTDIR=${RPM_BUILD_ROOT} PREFIX='' MANDIR=%{_mandir}
>
> or %make_install ?
%make_install didn't work for me, as I don't know how to force installation of
my binary (rfkill) in /sbin instead of /usr/sbin
>
>
>
> I'll throw you a free spectacle file for this package (created by
> autospectacle, our autopackager)
Thanks, I used it as a template and customized the generated .spec file
>
> Name : rfkill
> Version : 0.4
> Release : 1
> Group : Applications/System
> Summary : This is 'rfkill', a tool to use /dev/rfkill
> Description: |
> This is 'rfkill', a tool to use /dev/rfkill.
>
>
> To build rfkill, just enter 'make'.
> Sources :
> - http://wireless.kernel.org/download/rfkill/rfkill-%{version}.tar.bz2
>
> Configure : none
> License: ISC
> Files:
> - "%doc COPYING"
> - /usr/sbin/rfkill
> - /usr/share/man/man8/rfkill.8.gz
---------------------------------------------------------------------
Intel Corporation SAS (French simplified joint stock company)
Registered headquarters: "Les Montalets"- 2, rue de Paris,
92196 Meudon Cedex, France
Registration Number: 302 456 199 R.C.S. NANTERRE
Capital: 4,572,000 Euros
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
_______________________________________________
MeeGo-packaging mailing list
[email protected]
http://lists.meego.com/listinfo/meego-packaging
