On Tue, Aug 24, 2010 at 04:29:53PM +0200, Carsten Munk wrote:
> This is part 4 of 5 of a patchset implementing the following in MeeGo kernel:
>
> - Add OMAP DSS2 patches for supporting upgraded SGX driver:
> linux-2.6.35-OMAP-DSS2-in_use-flag-for-dss_cache.patch
> linux-2.6.35-OMAP-DSS2-Keep-track-whether-overlay-managers-are-en.patch
> linux-2.6.35-OMAP-DSS2-Add-GO-notifiers.patch
> - Upgrade N900 SGX drivers to 201003002 in order to not have a
> non-production snapshot of the drivers. Fixes BMC#5711
> - Add SGX platform device to N900 board file.
>
> These patches apply in order:
>
> linux-2.6.35-OMAP-DSS2-in_use-flag-for-dss_cache.patch
> linux-2.6.35-OMAP-DSS2-Keep-track-whether-overlay-managers-are-en.patch
> linux-2.6.35-OMAP-DSS2-Add-GO-notifiers.patch
> linux-2.6-N900-add-sgx-platform-device.patch
> linux-2.6-SGX-N900-upgrade-201003002.patch
>
> This patch adds a SGX platform device to the board configuration of N900
>
> Signed-off-by: Carsten Munk <[email protected]>
> Index: linux-2.6.34-master/arch/arm/mach-omap2/board-rx51-video.c
> ===================================================================
> --- linux-2.6.34-master.orig/arch/arm/mach-omap2/board-rx51-video.c
> 2010-08-04 10:31:38.000000000 +0000
> +++ linux-2.6.34-master/arch/arm/mach-omap2/board-rx51-video.c
> 2010-08-04 10:33:44.000000000 +0000
> @@ -66,8 +66,24 @@
> },
> };
>
> +static void rx51_sgx_dev_release(struct device *pdev)
> +{
> + pr_debug("%s: (%p)", __func__, pdev);
> +}
Oh no you don't. As per the documentation in the kernel, I get to now
mock you mercilessly for trying to do such a foolish thing!
Think about it, why would the kernel warn about not providing a release
function. Would it be to just force you to create an empty release
function like this just because I like you to type a bit more? No, it's
to solve the real problem here.
Please go read the kobject documentation and fix this up properly, this
code is completly broken.
Oh, and why aren't any of these patches already upstream in the main
kernel.org repo?
thanks,
greg k-h
_______________________________________________
MeeGo-dev mailing list
[email protected]
http://lists.meego.com/listinfo/meego-dev
