[ 
https://issues.apache.org/jira/browse/MAPREDUCE-7486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18068893#comment-18068893
 ] 

ASF GitHub Bot commented on MAPREDUCE-7486:
-------------------------------------------

deepujain opened a new pull request, #8388:
URL: https://github.com/apache/hadoop/pull/8388

   # MAPREDUCE-7486. Handling Cluster Storage Capacity Exceeded Exception with 
Enhanced Logging
   
   ## Summary
   This patch improves the logging path in `YarnChild.reportError()` when 
`ClusterStorageCapacityExceededException` is raised and fast fail is disabled. 
The task now emits a warning that explains why the job is not failing 
immediately and points users to the configuration that enables fast fail.
   
   ## Change
   - 
`hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapred/YarnChild.java`:
 add a warning log message for the non-fast-fail capacity-exceeded path.
   - 
`hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapred/TestYarnChild.java`:
 extend the unit coverage to assert the warning path and preserve the existing 
fatal-error behavior checks.
   
   ## Tests
   - `JAVA_HOME=/opt/homebrew/opt/openjdk /opt/homebrew/bin/mvn 
-Dmaven.repo.local=/tmp/codex-m2 test -pl 
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app 
-am -Dtest=TestYarnChild -DskipTests=false`
   
   ## JIRA
   Fixes MAPREDUCE-7486
   




> Handling Cluster Storage Capacity Exceeded Exception with Enhanced Logging
> --------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-7486
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-7486
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: mapreduce-client
>    Affects Versions: 3.3.6
>         Environment: Version: {{`3.3.6`}}
> Location: 
> {{{}`hadoop/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapred/YarnChild.java`{}}},
>  in {{`reportError`}} method, starting from Line 241-250.
>            Reporter: LoggingResearch
>            Priority: Major
>         Attachments: TestYarnChild.java, original-vs-log-enhanced.md
>
>
> The existing {{reportError}} method in {{YarnChild.java}} is responsible for 
> handling exceptions during job execution. However, when the exception is due 
> to the cluster storage capacity being exceeded, the method lacks sufficient 
> logging, especially in cases where the job is not configured to fast fail. 
> This can make it difficult for users to understand why a job did not fail 
> immediately when the storage capacity was exceeded. The enhancement adds 
> detailed logging to inform users about the configuration that prevents fast 
> failure.
>  
> *Expected Behavior:* 
> When a {{ClusterStorageCapacityExceededException}} is encountered, the system 
> should log whether the job is configured to fail fast. If fast fail is 
> disabled, the log should advise users on how to enable it.
>  
> *How-to-Fix:*
> We propose to *expose such a relationship by logging.*



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to