[
https://issues.apache.org/jira/browse/MAPREDUCE-7418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17924148#comment-17924148
]
ASF GitHub Bot commented on MAPREDUCE-7418:
-------------------------------------------
slfan1989 commented on PR #7350:
URL: https://github.com/apache/hadoop/pull/7350#issuecomment-2637305850
@cnauroth
The PR has the following points that need to be explained:
#### TestAMWebApp.java
In this unit test, EnvironmentVariables was introduced to simulate an SSL
environment by modifying the System.Env environment variables during runtime.
However, starting from JDK 9, direct modification of environment variables is
prohibited. Therefore, we replaced it with the recommended approach using
System.setProperty to set temporary variables. Additionally, we added logic in
the WebApps to retrieve environment variables to ensure the test runs smoothly.
#### TestStagingCleanup.java
The Checkstyle issues in this class cannot be automatically fixed due to an
extra space at the beginning of each line, which causes Checkstyle errors.
#### New Dependency: mockito-junit-jupiter
We introduced the mockito-junit-jupiter dependency to support the Mockito
mocking functionality required in the TestTaskAttemptListenerImpl class.
> Upgrade Junit 4 to 5 in hadoop-mapreduce-client-app
> ---------------------------------------------------
>
> Key: MAPREDUCE-7418
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7418
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: test
> Affects Versions: 3.3.4
> Reporter: Ashutosh Gupta
> Assignee: Ashutosh Gupta
> Priority: Major
> Labels: pull-request-available
>
> Upgrade Junit 4 to 5 in hadoop-mapreduce-client-app
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
