[
https://issues.apache.org/jira/browse/MAPREDUCE-7407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17605027#comment-17605027
]
ASF GitHub Bot commented on MAPREDUCE-7407:
-------------------------------------------
ashutoshcipher commented on code in PR #4779:
URL: https://github.com/apache/hadoop/pull/4779#discussion_r971432338
##########
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/launcher/TestContainerLauncherImpl.java:
##########
@@ -283,8 +283,24 @@ public void testOutOfOrder() throws Exception {
ut.handle(mockLaunchEvent);
ut.waitForPoolToIdle();
-
- verify(mockCM,
never()).startContainers(any(StartContainersRequest.class));
+
+ verify(mockCM).startContainers(any(StartContainersRequest.class));
+
+ LOG.info("inserting cleanup event");
+ ContainerLauncherEvent mockCleanupEvent2 =
Review Comment:
Makes sense, addressed.
> Avoid stopContainer() on dead node
> ----------------------------------
>
> Key: MAPREDUCE-7407
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7407
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Affects Versions: 3.3.4
> Reporter: Ashutosh Gupta
> Assignee: Ashutosh Gupta
> Priority: Major
> Labels: pull-request-available
>
> If a container failed to launch earlier due to terminated instances, it has
> already been removed from the container hash map. Avoiding the kill() for
> CONTAINER_REMOTE_CLEANUP will avoid wasting 15min per container on
> retries/timeout.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
