[
https://issues.apache.org/jira/browse/MAPREDUCE-7360?focusedWorklogId=637245&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-637245
]
ASF GitHub Bot logged work on MAPREDUCE-7360:
---------------------------------------------
Author: ASF GitHub Bot
Created on: 12/Aug/21 06:02
Start Date: 12/Aug/21 06:02
Worklog Time Spent: 10m
Work Description: LALAYANG opened a new pull request #3300:
URL: https://github.com/apache/hadoop/pull/3300
Link to issue:
[https://issues.apache.org/jira/browse/MAPREDUCE-7360](https://issues.apache.org/jira/browse/MAPREDUCE-7360)
## What is the purpose of this change
This PR is to clean shared state pollution between tests:
```
Test1:
org.apache.hadoop.mapreduce.v2.app.TestJobEndNotifier.testNotificationOnLastRetryShutdownWithRuntimeException
Test2:
org.apache.hadoop.mapreduce.v2.app.TestMRAppMaster.testMRAppMasterShutDownJob
```
- Test1 can pollute the shared state with Test2, which can lead Test2 to
fail after running Test1.
- It may be better to clean state pollutions so that some other tests won't
fail in the future due to the shared state polluted by this test.
## Reproduce test failure
First run Test1, then run Test2 in the same JVM
## Expected result
The tests should run successfully when multiple tests that use this state
are run in the same JVM.
## Actual result
Run Test1 and Test2, Test2 fails:
```
[ERROR] TestMRAppMaster.testMRAppMasterShutDownJob:530 Expected
shutDownJob to exit with status code of 0. expected:<0> but was:<1>
```
## Fix
Reset FirstExitException at the start of Test2 to clean the pollution from
Test1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 637245)
Remaining Estimate: 0h
Time Spent: 10m
> Clean shared state pollution to avoid flaky tests
> -------------------------------------------------
>
> Key: MAPREDUCE-7360
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7360
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: test
> Reporter: Yang Chen
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> h2. What is the purpose of this change
> This PR is to clean shared state pollution between tests:
> {code:java}
> Test1:
> org.apache.hadoop.mapreduce.v2.app.TestJobEndNotifier.testNotificationOnLastRetryShutdownWithRuntimeException
> Test2:
> org.apache.hadoop.mapreduce.v2.app.TestMRAppMaster.testMRAppMasterShutDownJob{code}
> Test1 can pollute the shared state with Test2, which can lead Test2 to fail
> after running Test1. It may be better to clean state pollutions so that some
> other tests won't fail in the future due to the shared state polluted by this
> test.
> h2. Reproduce test failure
> First run Test1, then run Test2 in the same JVM
> h2. Expected result
> The tests should run successfully when multiple tests that use this state are
> run in the same JVM.
> h2. Actual result
> Run Test1 and Test2, Test2 fails:
> {code:java}
> [ERROR] TestMRAppMaster.testMRAppMasterShutDownJob:530 Expected shutDownJob
> to exit with status code of 0. expected:<0> but was:<1>{code}
> h2. Fix
> Reset FirstExitException at the start of Test2 to clean the pollution from
> Test1.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
