can anyone review the updated PR for clang at least all of ryans' suggestions have been incorporated, and i think the conditional patch thing isn't much of a concern.
i don't want to keep making changes when it's fine now Thanks, Gagan > On Jul 30, 2025, at 1:31 PM, Frank Stock <[email protected]> wrote: > > Nope, you are all good. I just mis-understood, and thought you were saying > that since it took so long to build, you were just wanting to commit > pre-built binaries. > Simply my own lack of understanding about the process apparently. > > Thanks, > -Frank > >> On Jul 30, 2025, at 11:47 AM, Gagan Sidhu via macports-dev >> <[email protected]> wrote: >> >> i 100% agree with what you are saying. >> >> but ryan told me it won't build on the buildbots until its pushed. >> >> i am very confident all of these pushes *will* build on buildbot, because i >> built them on bone-stock VMs as-low as 10.6 >> >> there is no way i would ask or condone anyone to review a request that >> pushes non-buildbot-made builds onto other users. >> >> in this particular case, buildbot plays a crucial role since it will be >> building the macports-libcxx for every single distribution. >> >> if it fails on any OS, i am 100% in agreement that the macports-libcxx/clang >> will need to be reverted. >> - but again, we can't even start talking about that until its merged, >> since buildbot does not build PRs that haven't been merged. >> >> feel free to correct me if i am misunderstanding what you've explained to me >> in private, rydye >> >> Thanks, >> Gagan >> >>> On Jul 30, 2025, at 12:43 PM, Frank Stock <[email protected]> wrote: >>> >>> Apologies if I am mis-reading this request… >>> >>> My trust in the macports pre-built binaries is because it is my >>> understanding / belief that they are built by the build bots. >>> I would be uncomfortable with an externally built binary, on an unknown >>> machine, being pushed into the macports distribution. >>> >>> -Frank >>> >>>> On Jul 30, 2025, at 4:45 AM, Gagan Sidhu via macports-dev >>>> <[email protected]> wrote: >>>> >>>> >>>> Anybody? Please? >>>> >>>> >>>> Thanks, >>>> Gagan >>>> >>>> Sent from my (Inferior Android) BlackBerry—the (second-)most secure mobile >>>> device—via the Rogers Network. Long Live QNX >>>> >>>> >>>> >>>> Original Message >>>> >>>> >>>> From: [email protected] >>>> Sent: July 23, 2025 8:35 PM >>>> To: [email protected] >>>> Reply to: [email protected] >>>> Subject: PR 28819/28834 review >>>> >>>> >>>> https://github.com/macports/macports-ports/pull/28834 >>>> https://github.com/macports/macports-ports/pull/28819 >>>> >>>> need someone to review these PRs. >>>> >>>> clang doesn't finish within the 6 hour timer, but will build and work >>>> properly on 10.6+ for intel macs if someone decides to evaluate it. >>>> -it takes about 2 hours in a 10.6 VM with 16 cores and 16GB of ram. >>>> >>>> would appreciate pushing these, though i'm not sure how buildbot will >>>> distill the PRs to ready-made libraries for macports-libcxx, which will >>>> spare the leechers from having to endure what i have in testing and >>>> building the compiler (probably) 30+ times. >>> >> >
