> On May 1, 2016, at 7:51 PM, [email protected] wrote:
>
> Revision
> 148268
> Author
> [email protected]
> Date
> 2016-05-01 17:51:21 -0700 (Sun, 01 May 2016)
> Log Message
>
> rkhunter: new port (#16792)
>
Some comments:
> --- trunk/dports/sysutils/rkhunter/Portfile (rev 0)
> +++ trunk/dports/sysutils/rkhunter/Portfile 2016-05-02 00:51:21 UTC (rev
> 148268)
> +master_sites sourceforge
Should rewrite this as:
master_sites sourceforge:project/rkhunter/rkhunter/${version}/
to avoid redirects. See
https://trac.macports.org/wiki/howto/AvoidRedirects
> +destroot.target {}
When you want to clear a variable, it's better to just put no value:
destroot.target
> --- trunk/dports/sysutils/rkhunter/files/rkhunter.conf.local.sample
> (rev 0)
> +++ trunk/dports/sysutils/rkhunter/files/rkhunter.conf.local.sample
> 2016-05-02 00:51:21 UTC (rev 148268)
> @@ -0,0 +1,20 @@
> +# rkhunter.conf.local
> +
> +# version 1.0.0
> +# 20150316
> +# by Marius Schamschula
> +
> +# Tested under OS X 10.9.5
> +
> +# Apple installed files
> +RTKT_FILE_WHITELIST=/etc/sshd_config
> +RTKT_FILE_WHITELIST=/etc/ssh_host_key
> +
> +# Apple installed scripts
> +SCRIPTWHITELIST=/usr/bin/fuser
> +SCRIPTWHITELIST=/usr/bin/whatis
> +SCRIPTWHITELIST=/usr/bin/shasum
> +
> +# MacPorts installed scripts
> +SCRIPTWHITELIST=/opt/local/bin/egrep
> +SCRIPTWHITELIST=/opt/local/bin/fgrep
/opt/local should not be hardcoded. Instead use @PREFIX@, then use a reinplace
in a post-patch block in the Portfile to replace @PREFIX@ with ${prefix}.
_______________________________________________
macports-dev mailing list
[email protected]
https://lists.macosforge.org/mailman/listinfo/macports-dev
