Hi Herbert,
H Duerr a écrit :
Hi Eric,
Just a minor nitpick though. If a function returns a bool and a variable
caches this result like here
+ if(isAppleScrollBarVariantDoubleMax() == true )
+ ImplGetSVData()->maNWFData.mbIsScrollbarDoubleMax = true;
+ else
+ ImplGetSVData()->maNWFData.mbIsScrollbarDoubleMax = false;
then I prefer a direct assignment.
ouch, you are right :-)
I have modified that, and here is a new patch:
http://eric.bachard.free.fr/mac/aquavcl/patches/aquavcl03_august2007/scrollbar/scrollbar_new3.diff
Updating the settings is usually done in salframe because on most
platforms getting the settings requires a frame. In this case a frame is
not necessary (so salinstance would be even better), but for consistency
with other system settings keeping it in salframe is prefered.
I'm really divided: if ever an event informing us some System
preferences was modified, I think salinst would be prefered (all events
are implemented in it).
I remember Philipp adviced me to use something about that. It was "..
call SendInternalEvent( pThis, NULL,SALEVENT_SETTINGSCHANGED ) on your
SalDisplay, and this will cause SalFrame::UpdateSettings to be called
again ... ".
Is it possible to use such mechanism there ?
If there is an system event this is no problem.
I'll search one. Maybe Pavel told me about such event type (not sure)
Anyway, this remaining issue has a much lower priority than using the wrong
arrows or having a slow UI response, which are both fixed by your patch.
At least it works faster, but the counterpart is we cannot change the
prefs in runtime anymore (well, modify the arrows is not a video game ;)
The heart of the problem seems to stay in
vcl/source/control/scrbar.cxx,because I don't see any
IsNativeControlSupported() in it. Having such boolean would allow us to
check everything properly, and set the correct position for both
ButtonRect1, ButtonRect2 and ThumbRect. I'll wait a bit, and
investigate in that direction, before to commit anything.
Regards,
Eric Bachard
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
