On Mon, Oct 12, 2009 at 9:37 AM, JonY <[email protected]> wrote: > On 10/11/2009 22:39, Antonio Diaz Diaz wrote: >> >> Hello, >> >> JonY wrote: >>> >>> I noticed that lzip isn't particularly friendly to Windows. :) >> >> It depends on how you are trying to compile it. >> >> Wolfgang Buechel reported[1] that lzip can be compiled on windows with >> cygwin[2]. >> [1] http://lists.gnu.org/archive/html/lzip-bug/2009-08/msg00005.html >> [2] http://www.cygwin.com/ >> >> >>> Make check reports tests completed successfully. >> >> On your system maybe, but your patch breaks compilation on GNU/Linux. I >> can't accept a patch that doesn't work perfectly on GNU/Linux. >> > > Hi, > I built lzip as a native application with MinGW. It doesn't work with MSVC > yet, I'll get on it later. MSVC is missing "stdint.h". > > The issue is that all files need to be opened in binary mode with > _setmode(), especially when writing to stdout and piping to tar. > > Sorry, I didn't know O_BINARY was not available in Linux. Anyway, turns out > it wasn't needed if _setmode() was used. > > Tested with Gentoo and MinGW. > > Patch OK? >
Hi, I've attached a new patch, I removed some inconsistent coding styles and fixed a white space change.
w32.patch
Description: Binary data
_______________________________________________ Lzip-bug mailing list [email protected] http://lists.nongnu.org/mailman/listinfo/lzip-bug
