----- Original Message -----
> From: [email protected]
> To: "Jan Stancek" <[email protected]>
> Cc: [email protected]
> Sent: Thursday, 21 August, 2014 1:51:43 PM
> Subject: Re: [LTP] [PATCH] safe_macros: turn functions with off_t parameter 
> into static inline
> 
> Hi!
> > Some functions used to implement safe macros have parameters
> > of type off_t or structures containing off_t fields.
> > 
> > We don't want these to be compiled into libltp, because
> > some testcases are compiled with different flags such as:
> >   -D_FILE_OFFSET_BITS=64 -DOFF_T=__off64_t
> > which then creates incompatibility and testcases can fail.
> > 
> > For example sendfile06_64 on i386:
> >     sendfile06_64    1  TFAIL  :  sendfile06.c:90: sendfile(2) failed
> >           to return expected value, expected: 17592186044442, got: 26
> 
> Looks good, acked.

I tested it on
 RHEL6.0 (i386/x86_64/ppc64/s390x)
 RHEL6.5 (i386/x86_64/ppc64/s390x)
 RHEL7.0 (x86_64/ppc64/s390x)

and pushed.

Regards,
Jan

> 
> --
> Cyril Hrubis
> [email protected]
> 

------------------------------------------------------------------------------
Slashdot TV.  
Video for Nerds.  Stuff that matters.
http://tv.slashdot.org/
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to