Re: [llvm-commits] [llvm] r44384 - in /llvm/trunk: include/llvm/Analysis/LoopInfo.h include/llvm/CodeGen/MachineLoopInfo.h lib/CodeGen/MachineLoopInfo.cpp

[Bill Wendling]

Hi Owen,

Thanks! :-) A few comments:

> +  // isLoopHeader - True if the block is a loop header node

You probably want a /// comment here.

> +  virtual void print(std::ostream &O, const Module* M = 0) const {
> +    if (O) LI->print(O, M);
> +  }

I think that "if (O)" will always be true here, right?

> +// Allow clients to walk the list of nested loops...
> +template <> struct GraphTraits<const MachineLoop*> {
> +  typedef const MachineLoop NodeType;
> +  typedef std::vector<MachineLoop*>::const_iterator ChildIteratorType;

Should this be:

  typedef std::vector<const MachineLoop*>::const_iterator ChildIteratorType;

?

-bw
_______________________________________________
llvm-commits mailing list
llvm-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits