[llvm-commits] [llvm-gcc-4.0] r43856 - /llvm-gcc-4.0/trunk/gcc/llvm-convert.cpp

[Bill Wendling]

Author: void
Date: Wed Nov  7 18:10:45 2007
New Revision: 43856

URL: http://llvm.org/viewvc/llvm-project?rev=43856&view=rev
Log:
Revised FIXME comment

Modified:
    llvm-gcc-4.0/trunk/gcc/llvm-convert.cpp

Modified: llvm-gcc-4.0/trunk/gcc/llvm-convert.cpp
URL: 
http://llvm.org/viewvc/llvm-project/llvm-gcc-4.0/trunk/gcc/llvm-convert.cpp?rev=43856&r1=43855&r2=43856&view=diff

==============================================================================
--- llvm-gcc-4.0/trunk/gcc/llvm-convert.cpp (original)
+++ llvm-gcc-4.0/trunk/gcc/llvm-convert.cpp Wed Nov  7 18:10:45 2007
@@ -1297,7 +1297,10 @@
     CastToType(Instruction::BitCast, DestPtr, SBP),
     CastToType(Instruction::BitCast, SrcPtr, SBP),
     CastToSIntType(Size, IntPtr),
-    ConstantInt::get(Type::Int32Ty, 1) // FIXME: Hardcoding 1 here is a hack.
+    // FIXME: (PR1781) The alignment of DestPtr and SrcPtr may be different. We
+    // want the alignment of memcpy to be the minimal of the two. This isn't
+    // currently possible. Setting to 1 for the meantime.
+    ConstantInt::get(Type::Int32Ty, 1)
   };
 
   Intrinsic::ID IID = 
@@ -1313,7 +1316,10 @@
     CastToType(Instruction::BitCast, DestPtr, SBP),
     CastToType(Instruction::BitCast, SrcPtr, SBP),
     CastToSIntType(Size, IntPtr),
-    ConstantInt::get(Type::Int32Ty, Align)
+    // FIXME: (PR1781) The alignment of DestPtr and SrcPtr may be different. We
+    // want the alignment of memmove to be the minimal of the two. This isn't
+    // currently possible. Setting to 1 for the meantime.
+    ConstantInt::get(Type::Int32Ty, 1)
   };
 
   Intrinsic::ID IID = 
@@ -1329,7 +1335,10 @@
     CastToType(Instruction::BitCast, DestPtr, SBP),
     CastToSIntType(SrcVal, Type::Int8Ty),
     CastToSIntType(Size, IntPtr),
-    ConstantInt::get(Type::Int32Ty, 1) // FIXME: Hardcoding 1 here is a hack.
+    // FIXME: (PR1781) The alignment of DestPtr and SrcPtr may be different. We
+    // want the alignment of memset to be the minimal of the two. This isn't
+    // currently possible. Setting to 1 for the meantime.
+    ConstantInt::get(Type::Int32Ty, 1)
   };
 
   Intrinsic::ID IID = 


_______________________________________________
llvm-commits mailing list
llvm-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits