RiverDave wrote:

> Thank you for the PR. It looks great!
> 
> The current tests are not checking the `CIRFuncOpTargetLowering` code path, 
> it would be nice if you had a test that checked that as well.

Yes - I think we need a dedicated test suite that exercises the whole 
conversion process. workin' on it ^^

https://github.com/llvm/llvm-project/pull/179084
_______________________________________________
llvm-branch-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

Reply via email to